Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: noc user can edit note #3855

Merged
merged 2 commits into from
Mar 5, 2025
Merged

fix: noc user can edit note #3855

merged 2 commits into from
Mar 5, 2025

Conversation

talboren
Copy link
Member

@talboren talboren commented Mar 5, 2025

No description provided.

@talboren talboren linked an issue Mar 5, 2025 that may be closed by this pull request
Copy link

vercel bot commented Mar 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2025 7:49am

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 5, 2025
@dosubot dosubot bot added the Bug Something isn't working label Mar 5, 2025
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.98%. Comparing base (ec0bd45) to head (eebb401).
Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3855      +/-   ##
==========================================
+ Coverage   31.25%   31.98%   +0.73%     
==========================================
  Files          70       77       +7     
  Lines        8307     9147     +840     
==========================================
+ Hits         2596     2926     +330     
- Misses       5711     6221     +510     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@talboren talboren merged commit 1b049cc into main Mar 5, 2025
19 of 20 checks passed
@talboren talboren deleted the 3849-bug-noc-cannot-edit-note branch March 5, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: NOC cannot edit note
2 participants