Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow deleting all timestamps when lastReceived is omitted from delete alert API #3787

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jszeto9190
Copy link

Closes #2817

📑 Description

Currently, the DELETE /alerts API allows only a specific timestamp to be deleted or restored at a time, requiring lastReceived to be provided.

This update enhances the API by allowing all timestamps associated with an alert's fingerprint to be deleted when lastReceived is omitted.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Copy link

vercel bot commented Mar 2, 2025

@jszeto9190 is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 2, 2025
@CLAassistant
Copy link

CLAassistant commented Mar 2, 2025

CLA assistant check
All committers have signed the CLA.

@dosubot dosubot bot added API API related issues Documentation Improvements or additions to documentation Enhancement New feature or request labels Mar 2, 2025
@jszeto9190 jszeto9190 changed the title Allow deleting all timestamps when lastReceived is omitted from delete alert API feat: Allow deleting all timestamps when lastReceived is omitted from delete alert API Mar 2, 2025
@Kiryous Kiryous requested a review from Matvey-Kuk March 3, 2025 08:21
@Kiryous
Copy link
Contributor

Kiryous commented Mar 3, 2025

@jszeto9190 hey! thank you for the contribution. by the way, is "openapi.json" suppose to be there?

@jszeto9190
Copy link
Author

@Kiryous Hello! The reason it is in there is because I made some modifications to the documentation via that file. Please advise if there is a different way I should do it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API related issues Documentation Improvements or additions to documentation Enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[➕ Feature]: Delete Alerts using an API for all timestamps altogether
3 participants