Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improvements to incidents and providers #3067

Merged
merged 12 commits into from
Feb 1, 2025
Merged

docs: improvements to incidents and providers #3067

merged 12 commits into from
Feb 1, 2025

Conversation

talboren
Copy link
Member

@talboren talboren commented Jan 20, 2025 •
edited
Loading

close #3255

@vercel Vercel
Copy link

vercel bot commented Jan 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2025 2:48pm

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Documentation Improvements or additions to documentation labels Jan 20, 2025
Matvey-Kuk
Matvey-Kuk previously approved these changes Jan 21, 2025
View reviewed changes
@talboren talboren changed the title docs: improvements to incidents and providers [WIP] docs: improvements to incidents and providers Jan 21, 2025
@talboren talboren changed the title [WIP] docs: improvements to incidents and providers docs: improvements to incidents and providers Feb 1, 2025
@talboren talboren enabled auto-merge (squash) February 1, 2025 14:49
shahargl
shahargl approved these changes Feb 1, 2025
View reviewed changes
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 1, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 1, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 41.40%. Comparing base (5fec2ce) to head (5328cb6).
Report is 59 commits behind head on main.

Files with missing lines Patch % Lines
keep/topologies/topology_processor.py 33.33% 2 Missing ⚠️
keep/workflowmanager/workflowmanager.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3067      +/-   ##
==========================================
- Coverage   42.60%   41.40%   -1.20%     
==========================================
  Files         182      186       +4     
  Lines       17835    18786     +951     
==========================================
+ Hits         7598     7778     +180     
- Misses      10237    11008     +771

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@talboren talboren merged commit 4fd6937 into main Feb 1, 2025
17 of 20 checks passed
@talboren talboren deleted the docs/ai-demo branch February 1, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahargl shahargl shahargl approved these changes

@Matvey-Kuk Matvey-Kuk Matvey-Kuk left review comments

Assignees
No one assigned
Labels
Documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[📃 Docs]: Improvements to Incidents page and providers
3 participants
@talboren @Matvey-Kuk @shahargl