Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: backend workflow validation #2013

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

35C4n0r
Copy link
Contributor

@35C4n0r 35C4n0r commented Sep 27, 2024

Closes #1885
/claim #1885

📑 Description

  • Today "id" is being used as an name. This behavior has been deprecated.
  • If an id is supplied we use that, else we create a new one and add it to the workflow.
  • Names are not used for db queries anymore, except for in here
    workflow_id = get_workflow_id(tenant_id, workflow_name)
    , which handles the backwards compatibility.
  • parse method of Parser class is used for workflow validation.
  • Added a field called is_valid which checks the validity of the workflow.
  • UI changes:
    image

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Signed-off-by: 35C4n0r <[email protected]>
Copy link

vercel bot commented Sep 27, 2024

@35C4n0r is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

Signed-off-by: 35C4n0r <[email protected]>
@35C4n0r 35C4n0r changed the title feat: workflow fix feat: backend workflow validation Sep 27, 2024
@35C4n0r
Copy link
Contributor Author

35C4n0r commented Sep 27, 2024

fixing tests.

@35C4n0r
Copy link
Contributor Author

35C4n0r commented Sep 27, 2024

All tests pass PR ready for review

Copy link

vercel bot commented Sep 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2024 5:20pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[➕ Feature]: Improve workflow validation
1 participant