Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added dashboard for Alert Quality #1977

Merged
merged 74 commits into from
Oct 21, 2024
Merged

Conversation

vikashsprem
Copy link
Contributor

@vikashsprem vikashsprem commented Sep 21, 2024

Closes #1779
/claim #1779

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

Copy link

vercel bot commented Sep 21, 2024

@vikashsprem is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Sep 21, 2024

CLA assistant check
All committers have signed the CLA.

@vikashsprem vikashsprem marked this pull request as draft September 21, 2024 16:07
@vikashsprem vikashsprem changed the title Added UI for Alert Quality dashboard [Feat]: Added dashboard for Alert Quality Sep 21, 2024
@Matvey-Kuk
Copy link
Contributor

Hey @vikashsprem how is it going? :)

@vikashsprem
Copy link
Contributor Author

Hey, @Matvey-Kuk going great, need some time to complete it.

@vikashsprem
Copy link
Contributor Author

vikashsprem commented Sep 26, 2024

Hey @Matvey-Kuk, @rajeshj11 is also collaborating with me (To complete this issue sooner). Most of the portions are completed. Thank you.

feat: added the quality metrics stats logic in backend and minor modification on forntend
feat: added the providers filter tabs and custom filters
@vikashsprem
Copy link
Contributor Author

Hey @Matvey-Kuk, Please review this PR and let me know if any changes.

Screenshot 2024-09-27 at 1 15 06β€―PM

@vikashsprem vikashsprem marked this pull request as ready for review September 27, 2024 07:51
@vikashsprem vikashsprem changed the title [Feat]: Added dashboard for Alert Quality feat: Added dashboard for Alert Quality Sep 27, 2024
@Matvey-Kuk
Copy link
Contributor

Hey @vikashsprem I see you added a separate page for this dashboard, what do you think of making it a widget for the dashboard we already have? :)

@vikashsprem
Copy link
Contributor Author

vikashsprem commented Sep 27, 2024

Hey @Matvey-Kuk , Thanks for the suggestion! My concern with making it a widget is that the separate page allows us to include more detailed functionality without crowding the main dashboard. But I'm happy to discuss and find the best approach!

@Matvey-Kuk
Copy link
Contributor

@vikashsprem the main dashboard has a timeframe selector, also we're planning to add more widgets to this dashboard in the future to allow users to tail dashboards to their needs.

@vikashsprem
Copy link
Contributor Author

@Matvey-Kuk Got it, that makes sense! I'll look into transitioning the separate page into a widget.

Copy link
Contributor

@Matvey-Kuk Matvey-Kuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajeshj11 sorry for late reply! I've checked with Tal, the thing is that once the alert pops up in Keep and it doesn't have an Installed provider, a new type of providers is getting created called "Linked Providers", they are acting as any other providers, and I think they should be represented in the table.

Could you please update the PR?

@rajesh-jonnalagadda
Copy link
Contributor

@rajeshj11 sorry for late reply! I've checked with Tal, the thing is that once the alert pops up in Keep and it doesn't have an Installed provider, a new type of providers is getting created called "Linked Providers", they are acting as any other providers, and I think they should be represented in the table.

Could you please update the PR?

@Matvey-Kuk I did discuss this with @talboren. I proposed I will show all the provider type stats in separate table. Something like below.

Github(linked +installed) in a separate table.
Gitlab(linked+installed)

Should I maintain separate table. Need conformation

@Matvey-Kuk
Copy link
Contributor

@rajeshj11 I didn't mean a separate table, but just to include alerts from Linked + Installed in the widget you already added :)

@rajesh-jonnalagadda
Copy link
Contributor

@rajeshj11 I didn't mean a separate table, but just to include alerts from Linked + Installed in the widget you already added :)

https://www.loom.com/share/03e52b1f785d4a039e47d0aa124c41b6

please check the demo

@Matvey-Kuk
Copy link
Contributor

@rajeshj11 looks cool!

@vikashsprem
Copy link
Contributor Author

vikashsprem commented Oct 20, 2024

Hey @Matvey-Kuk the latest changes have been applied, Please review.

Copy link
Contributor

@Matvey-Kuk Matvey-Kuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I noticed a bug:

  1. I click "Add Fields", add a few fields.
  2. I save dashboard.
  3. I reload the page.
  4. I don't see fields I added.
Screenshot 2024-10-20 at 16 06 58

@rajesh-jonnalagadda
Copy link
Contributor

Great! I noticed a bug:

  1. I click "Add Fields", add a few fields.
  2. I save dashboard.
  3. I reload the page.
  4. I don't see fields I added.
Screenshot 2024-10-20 at 16 06 58

We have not configured it like that. fields act like filters. those are not part of the configuration implementation.

@Matvey-Kuk
Copy link
Contributor

@rajeshj11 wouldn't it be confusing for users?

@rajesh-jonnalagadda
Copy link
Contributor

@rajeshj11 wouldn't it be confusing for users?

Yes, I agree it could cause some confusion. We can definitely work on improving this.

@rajesh-jonnalagadda
Copy link
Contributor

@rajeshj11 wouldn't it be confusing for users?

@Matvey-Kuk The way we’ve implemented itβ€”adding this in the configβ€”would require significant effort. Should we create a subtask to address this?"

@rajesh-jonnalagadda
Copy link
Contributor

rajesh-jonnalagadda commented Oct 20, 2024

@rajeshj11 wouldn't it be confusing for users?

@Matvey-Kuk The way we’ve implemented itβ€”adding this in the configβ€”would require significant effort. Should we create a subtask to address this?"

I have a quick alternate solution for this. We can persist the widget table filters in local storage, so even after a refresh, it will retrieve the latest filters from local storage. what do you think?

@Matvey-Kuk
Copy link
Contributor

@rajeshj11 the use-case I see is someone adding fields and sending the dashboard link to a colleague. It won't work in case it will be stored in the local storage.

@vikashsprem
Copy link
Contributor Author

vikashsprem commented Oct 20, 2024

Hey @Matvey-Kuk, we have made changes according to your suggestion. Please review for more, we have attached a demo video (Some blinking issues in the video not in the actual application) have a look.

https://www.loom.com/share/e8f8138b34da4836ae776088b11c406f

Copy link
Contributor

@Matvey-Kuk Matvey-Kuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you!

@Matvey-Kuk Matvey-Kuk enabled auto-merge (squash) October 21, 2024 08:00
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Matvey-Kuk Matvey-Kuk merged commit 5a93f10 into keephq:main Oct 21, 2024
8 checks passed
Copy link
Contributor

πŸ† Fantastic work @vikashsprem! Your very first PR to keep has been merged! πŸŽ‰πŸ₯³

You've just taken your first step into open-source, and we couldn't be happier to have you onboard. πŸ™Œ
If you're feeling adventurous, why not dive into another issue and keep contributing? The community would love to see more from you! πŸš€

For any support, feel free to reach out on the community: https://slack.keephq.dev. Happy coding! πŸ‘©β€πŸ’»πŸ‘¨β€πŸ’»

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[βž• Feature]: Alert quality widgets for a dashboard
5 participants