-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added dashboard for Alert Quality #1977
Conversation
@vikashsprem is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
Hey @vikashsprem how is it going? :) |
Hey, @Matvey-Kuk going great, need some time to complete it. |
Hey @Matvey-Kuk, @rajeshj11 is also collaborating with me (To complete this issue sooner). Most of the portions are completed. Thank you. |
β¦fications on forntend
feat: added the quality metrics stats logic in backend and minor modification on forntend
feat: added the providers filter tabs and custom filters
Hey @Matvey-Kuk, Please review this PR and let me know if any changes. |
feat: intergated the custom filters
Hey @vikashsprem I see you added a separate page for this dashboard, what do you think of making it a widget for the dashboard we already have? :) |
Hey @Matvey-Kuk , Thanks for the suggestion! My concern with making it a widget is that the separate page allows us to include more detailed functionality without crowding the main dashboard. But I'm happy to discuss and find the best approach! |
@vikashsprem the main dashboard has a timeframe selector, also we're planning to add more widgets to this dashboard in the future to allow users to tail dashboards to their needs. |
@Matvey-Kuk Got it, that makes sense! I'll look into transitioning the separate page into a widget. |
feat: move the quality table report to dashbaord.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rajeshj11 sorry for late reply! I've checked with Tal, the thing is that once the alert pops up in Keep and it doesn't have an Installed provider, a new type of providers is getting created called "Linked Providers", they are acting as any other providers, and I think they should be represented in the table.
Could you please update the PR?
@Matvey-Kuk I did discuss this with @talboren. I proposed I will show all the provider type stats in separate table. Something like below. Github(linked +installed) in a separate table. Should I maintain separate table. Need conformation |
@rajeshj11 I didn't mean a separate table, but just to include alerts from Linked + Installed in the widget you already added :) |
https://www.loom.com/share/03e52b1f785d4a039e47d0aa124c41b6 please check the demo |
@rajeshj11 looks cool! |
chore: fix feedback changes
Hey @Matvey-Kuk the latest changes have been applied, Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rajeshj11 wouldn't it be confusing for users? |
Yes, I agree it could cause some confusion. We can definitely work on improving this. |
@Matvey-Kuk The way weβve implemented itβadding this in the configβwould require significant effort. Should we create a subtask to address this?" |
I have a quick alternate solution for this. We can persist the widget table filters in local storage, so even after a refresh, it will retrieve the latest filters from local storage. what do you think? |
@rajeshj11 the use-case I see is someone adding fields and sending the dashboard link to a colleague. It won't work in case it will be stored in the local storage. |
chore: add default filters in dashboard config
Hey @Matvey-Kuk, we have made changes according to your suggestion. Please review for more, we have attached a demo video ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
π Fantastic work @vikashsprem! Your very first PR to keep has been merged! ππ₯³ You've just taken your first step into open-source, and we couldn't be happier to have you onboard. π For any support, feel free to reach out on the community: https://slack.keephq.dev. Happy coding! π©βπ»π¨βπ» |
Closes #1779
/claim #1779
π Description
β Checks
βΉ Additional Information