Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add topology applications #1975

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

Kiryous
Copy link
Contributor

@Kiryous Kiryous commented Sep 19, 2024

Closes #1968

  • Frontend: Create/manage application form
  • Frontend: Create application node and add child services to draw on react-flow
  • Backend: CRUD
  • Backend: Tests
  • Frontend: update hooks to work with actual endpoints
  • Frontend: ensure useTopology() hook doesn't cause multiple polling
  • Docs

Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Sep 29, 2024 7:44am

@Kiryous Kiryous marked this pull request as draft September 19, 2024 16:48
@talboren talboren changed the title feat: add topology applications UI (mocked API for now) [wip] [WIP] feat: add topology applications UI (mocked API for now) Sep 19, 2024
# Conflicts:
#	keep-ui/utils/hooks/useTopology.ts
@Kiryous Kiryous changed the title [WIP] feat: add topology applications UI (mocked API for now) [WIP] feat: add topology applications Sep 23, 2024
@Kiryous Kiryous changed the title [WIP] feat: add topology applications feat: add topology applications Sep 26, 2024
@Kiryous Kiryous marked this pull request as ready for review September 26, 2024 22:58
@talboren
Copy link
Member

@Kiryous please note that build fails
Module not found: Can't resolve '../topology/map/ui/topology-page'

@Kiryous
Copy link
Contributor Author

Kiryous commented Sep 28, 2024

@talboren fixed

@talboren
Copy link
Member

@talboren fixed

now e2e tests failed (db couldn't start for some reason ;()

@talboren
Copy link
Member

@talboren fixed

now e2e tests failed (db couldn't start for some reason ;()

@Kiryous
keep-backend-1 | raise util.CommandError(multiple_heads) from mh keep-backend-1 | alembic.util.exc.CommandError: Multiple head revisions are present for given argument 'head'; please specify a specific target revision, '<branchname>@head' to narrow to a specific head, or 'heads' for all heads

Seems like there were some migrations since you created this branch and your migration is out of date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[➕ Feature] Allow to group services into applications in topology
2 participants