-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add topology applications #1975
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
# Conflicts: # keep-ui/utils/hooks/useTopology.ts
Co-authored-by: Tal Borenstein <[email protected]>
@Kiryous please note that build fails |
@talboren fixed |
now e2e tests failed (db couldn't start for some reason ;() |
@Kiryous Seems like there were some migrations since you created this branch and your migration is out of date. |
"Show on the map" feature doesn't work for me if nodes are far from each other vertically. It positions the view in between and the view is too zoomed-in to show all services for the app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1975 +/- ##
===========================================
- Coverage 69.95% 31.42% -38.54%
===========================================
Files 150 57 -93
Lines 13297 5980 -7317
===========================================
- Hits 9302 1879 -7423
- Misses 3995 4101 +106
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Closes #1968
useTopology()
hook doesn't cause multiple polling