Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Auto-Type select dialog even if window title is empty #11603

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

droidmonkey
Copy link
Member

There were a couple code paths that did not reset the state appropriately and could cause undefined behavior in the auto-type processing.

I split the changes into two commits.

Testing strategy

Tested on Windows with simulated window title being blank. The select dialog properly displays with the "Search all databases" checkbox checked as expected.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

There were a couple code paths that did not reset the state appropriately and could cause undefined behavior in the auto-type processing.
@droidmonkey droidmonkey added feature: Auto-Type pr: bugfix Pull request that fixes a bug labels Dec 27, 2024
@droidmonkey droidmonkey added this to the v2.7.10 milestone Dec 27, 2024
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.88%. Comparing base (e76e9d4) to head (c8c59fb).

Files with missing lines Patch % Lines
src/autotype/AutoType.cpp 88.24% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11603      +/-   ##
===========================================
+ Coverage    63.84%   63.88%   +0.04%     
===========================================
  Files          362      362              
  Lines        38169    38163       -6     
===========================================
+ Hits         24368    24379      +11     
+ Misses       13801    13784      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: Auto-Type pr: bugfix Pull request that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconfigure how auto-type behaves when the window title is blank
1 participant