fix: calc tests #552
Open
fix: calc tests #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarboq
reviewed
Oct 22, 2023
zarboq
reviewed
Oct 22, 2023
| // ); | ||
| // assert(roundup_magnitude_division(i128_new(0, false), 12) == i128_new(0, false), '0/12 should be 0'); | ||
| assert( | ||
| roundup_magnitude_division(i128_new(12, true), 3) == i128_new(5, true), '-12/3 should be -4' |
| roundup_magnitude_division(i128_new(9, false), 9) == i128_new(1, false), '9/9 should be 1' | ||
| ); | ||
| assert( | ||
| roundup_magnitude_division(i128_new(9, true), 9) == i128_new(2, true), '-9/9 should be -1' |
| sum_return_uint_128( | ||
| BoundedInt::max(), min_i128() + i128_new(1, false) | ||
| ) == max_i128_as_u128() | ||
| + 2, |
There was a problem hiding this comment.
Getting +1 with gmx but this might be related to the issue we discussed with custom implementation
Sk8erboi84
approved these changes
Oct 23, 2023
dbejarano820
approved these changes
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
What is the new behavior?
Does this introduce a breaking change?
No