-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testing cicd #141
testing cicd #141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the ci action looks good, but it appears something happened with the README in your PR. Can you clean this before we merge this?
I added a few lines in the readme: https://github.com/keep-starknet-strange/blobstream-starknet/pull/141/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R25 sadly the crlf seems wrong :/ |
I will look for the git command to remove crlf on windows tommowor. |
I did:
did not changed nothing. any idea of why? |
pleeeeease!! |
Looks like the README is still edited in the PR. Maybe just create a clean branch and only commit the cicd file? |
If you need I can create a new PR and just update it with your git action and add you as a reviewer. You will still get paid for the contribution through OnlyDust. lmk |
@drspacemn it is ok if you can author me. thanks :) |
@drspacemn can I get news please? |
@drspacemn I do not have any news. can I continue the PR alone finally then please? I do not want to override your work. |
Hello. As mentionned in private, I would like to know if I can finish it alone or if it will bother you because you could be still busy to do it alone by yourself. I do not want to overrride your work. |
Sorry for the delay. I have not done the work so feel free to complete yourself. |
I am going to do it. |
ready to merge! |
nice work, thank you! |
Does not compile on windows. Should I document it?
Reday for a review.