Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing cicd #141

Merged
merged 3 commits into from
May 22, 2024
Merged

testing cicd #141

merged 3 commits into from
May 22, 2024

Conversation

gogo2464
Copy link
Contributor

@gogo2464 gogo2464 commented Apr 16, 2024

Does not compile on windows. Should I document it?

Reday for a review.

Copy link
Contributor

@drspacemn drspacemn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ci action looks good, but it appears something happened with the README in your PR. Can you clean this before we merge this?

@gogo2464
Copy link
Contributor Author

@gogo2464
Copy link
Contributor Author

I will look for the git command to remove crlf on windows tommowor.

@gogo2464
Copy link
Contributor Author

I did:

git config --global core.autocrlf true
git config --global core.safecrlf false

did not changed nothing. any idea of why?

@gogo2464
Copy link
Contributor Author

pleeeeease!!

@drspacemn
Copy link
Contributor

Looks like the README is still edited in the PR. Maybe just create a clean branch and only commit the cicd file?

@drspacemn
Copy link
Contributor

drspacemn commented Apr 28, 2024

If you need I can create a new PR and just update it with your git action and add you as a reviewer. You will still get paid for the contribution through OnlyDust. lmk

@gogo2464
Copy link
Contributor Author

@drspacemn it is ok if you can author me. thanks :)

@gogo2464
Copy link
Contributor Author

gogo2464 commented May 3, 2024

@drspacemn can I get news please?

@gogo2464
Copy link
Contributor Author

@drspacemn I do not have any news. can I continue the PR alone finally then please? I do not want to override your work.

@gogo2464
Copy link
Contributor Author

Hello.

As mentionned in private, I would like to know if I can finish it alone or if it will bother you because you could be still busy to do it alone by yourself.

I do not want to overrride your work.

@drspacemn
Copy link
Contributor

Sorry for the delay. I have not done the work so feel free to complete yourself.

@gogo2464
Copy link
Contributor Author

I am going to do it.

@gogo2464
Copy link
Contributor Author

ready to merge!

@drspacemn
Copy link
Contributor

nice work, thank you!

@drspacemn drspacemn merged commit b74777e into keep-starknet-strange:main May 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants