-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: use sol abi traits #128
dev: use sol abi traits #128
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is great, just the mutable variables should probably be changed now.
src/blobstreamx.cairo
Outdated
let mut data_root_bytes = BytesTrait::new_empty(); | ||
data_root_bytes.append_felt252(data_root.height); | ||
data_root_bytes.append_u256(data_root.data_root); | ||
let mut data_root_bytes = BytesTrait::new_empty() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these variables don't need to be mut
anymore with this setup. Hope that's not too much to change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed they don't!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool to see this being used!
It's more intuitive. You know at a glance whether it's packed or not |
Updated use of
append_X
tosol_abi
'sencode_packed
.