Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: Comments and naming patches, typo fixes #112

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

b-j-roberts
Copy link
Contributor

@b-j-roberts b-j-roberts commented Mar 11, 2024

Update comments, patched some names in the fee vault, indexed fee vault event keys, and typos

  • issue #
  • follows contribution guide
  • code change includes tests
  • breaking change

@b-j-roberts b-j-roberts added dev Non-functional work contract labels Mar 11, 2024
Copy link

vercel bot commented Mar 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blobstream-starknet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2024 1:50pm

Copy link
Contributor

@drspacemn drspacemn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@drspacemn drspacemn merged commit 7d88b37 into main Mar 12, 2024
5 checks passed
@drspacemn drspacemn deleted the dev/brandon-patch-things branch March 12, 2024 14:11
thomas192 pushed a commit to thomas192/blobstream-starknet that referenced this pull request Mar 14, 2024
* Update comments, patched some names in the fee vault, indexed fee vault event keys, and typos

* scarb fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contract dev Non-functional work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants