Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented namespace hash digest #101

Merged
merged 10 commits into from
Feb 16, 2024
Merged

Implemented namespace hash digest #101

merged 10 commits into from
Feb 16, 2024

Conversation

Akashneelesh
Copy link
Contributor

Implemented namespace hasher and added tests for the same.

@vercel Vercel
Copy link

vercel bot commented Feb 14, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blobstream-starknet ❌ Failed (Inspect) Feb 16, 2024 2:38pm

b-j-roberts
b-j-roberts reviewed Feb 15, 2024
View reviewed changes
Copy link
Contributor

@b-j-roberts b-j-roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some reviews; please resolve them and also use the scarb fmt command for code formatting tests to pass.

src/tree/namespace/hasher.cairo Outdated Show resolved Hide resolved
src/tree/namespace/hasher.cairo Outdated Show resolved Hide resolved
src/tree/namespace/hasher.cairo Outdated Show resolved Hide resolved
src/tree/namespace/hasher.cairo Outdated Show resolved Hide resolved
src/tree/namespace/hasher.cairo Outdated Show resolved Hide resolved
src/tree/namespace/tests/test_hasher.cairo Outdated Show resolved Hide resolved
src/tree/namespace/tests/test_hasher.cairo Outdated Show resolved Hide resolved
src/tree/namespace/tests/test_hasher.cairo Outdated Show resolved Hide resolved
src/tree/namespace/tests/test_hasher.cairo Outdated Show resolved Hide resolved
src/tree/tests/test_consts.cairo Outdated Show resolved Hide resolved
@Akashneelesh
Copy link
Contributor Author

I left some reviews; please resolve them and also use the scarb fmt command for code formatting tests to pass.

I have addressed the comments and have resolved it.

b-j-roberts
b-j-roberts approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@b-j-roberts b-j-roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@b-j-roberts b-j-roberts merged commit 01c1ad6 into keep-starknet-strange:main Feb 16, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-j-roberts b-j-roberts b-j-roberts approved these changes

@drspacemn drspacemn Awaiting requested review from drspacemn drspacemn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Akashneelesh @b-j-roberts