Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generic byte reader reopen #225

Merged
merged 4 commits into from
Dec 12, 2023
Merged

feat: generic byte reader reopen #225

merged 4 commits into from
Dec 12, 2023

Conversation

sveamarcus
Copy link
Contributor

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Please see pull request 199 for background. Reopened here minus Serde which has been added to byte_array of core.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@sveamarcus sveamarcus requested a review from 0xLucqs as a code owner December 7, 2023 10:36
0xLucqs
0xLucqs requested changes Dec 8, 2023
View reviewed changes
src/data_structures/src/byte_appender.cairo Outdated Show resolved Hide resolved
src/data_structures/src/byte_appender.cairo Outdated Show resolved Hide resolved
src/data_structures/src/byte_appender.cairo Outdated Show resolved Hide resolved
src/data_structures/src/byte_appender.cairo Show resolved Hide resolved
src/data_structures/src/byte_reader.cairo Outdated Show resolved Hide resolved
0xLucqs
0xLucqs requested changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@0xLucqs 0xLucqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also can you check if ByteArray doesn't suit all your needs ?

src/data_structures/src/byte_reader.cairo Outdated Show resolved Hide resolved
@sveamarcus
Copy link
Contributor Author

also can you check if ByteArray doesn't suit all your needs ?

Can you elaborate a bit please? Which part were you thinking of?

0xLucqs
0xLucqs reviewed Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@0xLucqs 0xLucqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parse_signed already returns an option so no need to do Option::Some(pars_signed(x, y)?) just return parse_signed(x, y)

@0xLucqs
Copy link
Collaborator

0xLucqs commented Dec 11, 2023

this

@0xLucqs 0xLucqs merged commit ecc881e into keep-starknet-strange:main Dec 12, 2023
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@0xLucqs 0xLucqs 0xLucqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sveamarcus @0xLucqs