SUPPORT-13291 fix installing keboola.component when there are no packages defined #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipeline for main runs only when there's any tag as defined by the tags: ["*"] below
…stall keboola.component
kudj
approved these changes
Sep 3, 2025
| - bug/* | ||
| - fix/* | ||
| branches-ignore: | ||
| - main |
There was a problem hiding this comment.
nice! let’s add this also to the cookiecutter template, please 🙏
Contributor
Author
There was a problem hiding this comment.
Yep, planned to do that 🙂 I was just tired of having to examine push.yml to pick a branch name every time, so I figured out this… It's also possible to use:
branches:
- "!main"
but then you have to enter at least one other non-excluding rule. "*" would probably be enough, but I consider my solution more readable. 👍
ujovlado
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also the packages in
"source": "code"mode are installed using uv's pip interface (uv pip install) instead of the project interface (uv add) which unintentionally used the pyproject and uv.lock files of the Custom Python component itself.This PR also fixes the tests, as this scenario wasn't covered (tests 7 & 8 were a bit redundant, so I replaced them to cover this).