fix: prevent crash on __weak NSWindow ref from JNI thread during disposal#100
Merged
kdroidFilter merged 1 commit intomainfrom Mar 10, 2026
Merged
fix: prevent crash on __weak NSWindow ref from JNI thread during disposal#100kdroidFilter merged 1 commit intomainfrom
kdroidFilter merged 1 commit intomainfrom
Conversation
…osal nativeRemoveMenuBarMonitor and nativeResetTitleBar create a __weak NSWindow reference on the AWT-EventQueue thread. If the NSWindow has already been deallocated on the main thread, objc_initWeak accesses freed memory causing EXC_BAD_ACCESS (SIGABRT). Instead, capture the raw pointer and dispatch to the main thread, then validate the window is still alive via [NSApp windows] before accessing it. Pointer comparison is safe even for freed pointers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__weak NSWindow*references on the AWT-EventQueue Java thread viaobjc_initWeak, which accesses the object's memory — crashing withEXC_BAD_ACCESSif theNSWindowwas already deallocated on the main threaddispatch_asyncto main thread, validating the window is still alive via[NSApp windows]pointer comparison before accessing itTest plan