Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: check for props in parser func #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: check for props in parser func #21

wants to merge 2 commits into from

Conversation

freefony
Copy link
Collaborator

fix #20

@freefony freefony requested a review from kdoran October 23, 2018 18:13
kdoran
kdoran approved these changes Oct 24, 2018
View reviewed changes
Copy link
Owner

@kdoran kdoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one Femi!

Only thing I'd suggest is changing the message "Invalid Response" to "Unexpected response", because there's probably a few other CouchDB requests the user could come up with and we haven't thought of all of them :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdoran kdoran kdoran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

output expects response to be an object
2 participants
@freefony @kdoran