-
Notifications
You must be signed in to change notification settings - Fork 14
Add system:cluster:... groups to effective users #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Nelo-T. Wallus <[email protected]> Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]> Signed-off-by: Nelo-T. Wallus <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for system:cluster:... groups to effective users based on authentication.kcp.io/scopes, extending the existing warrant and scope functionality to include cluster-scoped group memberships for authorization purposes.
- Adds ClusterScopeKey constant and sets cluster scope for service accounts
- Introduces EffectiveScopes function to compute intersections of user scopes
- Updates effective user logic to add system:cluster: groups based on scopes
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| staging/src/k8s.io/apiserver/pkg/authentication/serviceaccount/util.go | Adds ClusterScopeKey constant and sets cluster scope in service account UserInfo |
| pkg/registry/rbac/validation/kcp.go | Implements EffectiveScopes function and updates effective user logic to add cluster groups |
| pkg/registry/rbac/validation/kcp_test.go | Updates tests to use constants and adds comprehensive test coverage for EffectiveScopes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
mjudeikis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not with easy hand. This feels complex :D
/lgtm
/apprve
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds the extra
authentication.kcp.io/scopesto service accounts similar to per-workspace auth users.Adds the group
system:cluster:...to effective users based off ofauthentication.kcp.io/scopes.Needed for github.com/kcp-dev/kcp/pull/3530
Problems
Users that do not originate from per-ws auth and do not have a warrant or scope cannot get a
system:cluster:....Originally I had added the group explicitly for APIBinding requests and allowed the group through here. However that pattern would require adding the
system:cluster:group wherever cross-ws requests can happen.A potential solution could be what this PR proposes with building the groups based off of the scopes as well as allowing
system:clluster:group through, adding those groups explicitly where necessary (e.g. in APIBinding) request.Since per-ws auth does not allow setting
system:groups coming from the auth provider that could be reasonably secure. Although it feels very hacky.Alternatively we'd have to update EffectiveUsers/Groups to get the information on the source and target cluster so the correct info can be calculated more accurately.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: