Skip to content

Support creation of records while not being assigned to any institution #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
palagdan wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Support creation of records while not being assigned to any institution #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
770248c
[#302] Support optional institution column
palagdan Oct 30, 2025
6c76a77
[#302] Fix and implement new tests
palagdan Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/record/RecordRow.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,13 @@ const RecordRow = (props) => {
{`${record.author.firstName} ${record.author.lastName}`}
</Button>
) : (
<span className="text-warning">Not Found</span>
"—"
)}
</td>
)}

{props.visibleColumns.includes(COLUMNS.INSTITUTION) && (
<td className="report-row content-center">{record.institution.name}</td>
<td className="report-row content-center">{record.institution ? record.institution.name : "—"}</td>
)}

{props.visibleColumns.includes(COLUMNS.TEMPLATE) && (
Expand Down
9 changes: 7 additions & 2 deletions tests/__tests__/components/RecordRow.spec.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,16 +85,21 @@ describe("RecordRow", function () {
expect(screen.queryByText("Thomas Shelby")).not.toBeInTheDocument();
});

it("renders 'Not Found' for author if firstName or lastName are missing", () => {
it("renders '—' for author if firstName or lastName are missing", () => {
renderComponent({ record: { ...defaultProps.record, author: { username: "Thomas" } } });
expect(screen.getByText("Not Found")).toBeInTheDocument();
expect(screen.getByText("—")).toBeInTheDocument();
});

it("renders institution if it is visible", () => {
renderComponent();
expect(screen.getByText(defaultProps.record.institution.name)).toBeInTheDocument();
});

it("renders '—' for institution if it is missing", () => {
renderComponent({ record: { ...defaultProps.record, institution: null } });
expect(screen.getByText("—")).toBeInTheDocument();
});

it("does not render institution if it is not visible", () => {
renderComponent({ visibleColumns: Object.values(COLUMNS).filter((col) => col !== COLUMNS.INSTITUTION) });
expect(screen.queryByText(defaultProps.record.institution.name)).not.toBeInTheDocument();
Expand Down