-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use File Object instead filename #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Do you want me to complete the implementation of this task or do you like the idea and will implement it yourself? What should I do? PR cannot be used without modifications, it's only concept, not yet realization. |
I'd love to do it but won't be able to get to it for a couple of weeks. Do you have the bandwidth to handle it before then? |
Yes, I will try. The task doesn't look difficult. Only in the part where I need to maintain backward compatibility for all functions. I hope you will be in touch to discuss if there are any controversial issues in my proposals. |
Absolutely! |
Move discussion to PR-4 |
First of all, thank you for your work.
This is draft PR. I will prepare it for uploading to the main if you confirm that you are not conceptually against the proposed changes.
Changes will help to use library in http services, which take data from resources. And maybe in other cases. For example, I came across the fact that I can read a file from resources in the following way in my project.
But I can't directly pass the filename. Therefore, I propose to support file object transfer with minimal changes.