83. Remove Duplicates from Sorted List #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayashi-ay
reviewed
Nov 8, 2024
| if head is None: | ||
| return None | ||
| current = head | ||
| while current.next is not None: |
There was a problem hiding this comment.
正常系では、1回のループでノードが１つ進むとするとif文はcontinueして、elseを消すのもありかもしれないです。
while current.next is not None:
if current.val == current.next.val:
current.next = current.next.next
continue
current = current.nextThere was a problem hiding this comment.
ありがとうございます。
「1回のループでノードが１つ進む感じが伝わる」のと「early returnみたいでスッキリする」ので、いいですね！
oda
reviewed
Nov 8, 2024
| https://www.python.jp/news/wnpython311/inline-function.html | ||
|
|
||
|
|
||
| - Discordを見ていて`current`という変数の命名について無意識についけていたことに気づいた。別の候補として`current_node`や`current_focusing_node`を思いついた。しかし、今回は短い処理であり、今注目しているノードという点は伝わる範囲だと思うので、`current`という変数名を使うことにする。もっと長い処理場合は、より意味のこもった変数名にする。 |
There was a problem hiding this comment.
本当に上から読んでいって明らかならば node だけでもいいと思うんですよね。読み手に何を伝えたいか次第です。
for i in range(len(array)): と書かれていたら、添字の配列であろうとほぼ確信して次にいけるわけです。
これが長くても迷彩か擬態にしかなりません。
https://discord.com/channels/1084280443945353267/1200089668901937312/1209882689411223644
https://discord.com/channels/1084280443945353267/1225849404037009609/1234218057199784077
|
良いと思います！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/remove-duplicates-from-sorted-list/description/