Max Area of Island.md #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liquo-rice
reviewed
Jan 8, 2025
| def maxAreaOfIsland(self, grid: List[List[int]]) -> int: | ||
| WATER = 0 | ||
| max_area = 0 | ||
| seen = set() |
oda
reviewed
Jan 8, 2025
|
|
||
| - 書いた後の感想 | ||
| - 昨日までは、「自分の中の最適値として暗記したコードを、出力している」という感覚が若干あった。（そのつもりはなかったけど、今日振り返るとそう感じる） | ||
| - 今日は、暗記というより「書くべきことを順次考えつつ、順次書く」という感じに変わった気がした。 |
There was a problem hiding this comment.
コードはいいと思います。
20-30問くらい解いたところで感想記事をネットに公開していただけると助かります。
nodchip
reviewed
Jan 8, 2025
| row, col = islands.pop() | ||
| if (row, col) in seen: | ||
| continue | ||
| if not (0 <= row < len(grid) and 0 <= col < len(grid[0])): |
There was a problem hiding this comment.
num_rows = len(grid)
num_cols = len(grid[0])とおいておくと、 len(grid) と len(grid[0]) のどちらが縦でどちらが横か毎回考えずに済み、読みやすくなると思います。
colorbox
reviewed
Jan 9, 2025
| class Solution: | ||
| def maxAreaOfIsland(self, grid: List[List[int]]) -> int: | ||
| WATER = 0 | ||
| max_area = 0 |
There was a problem hiding this comment.
宣言から利用まで距離がありますね。
宣言の場所を最後のfor文の直前にすると良いと思います。
変数について覚えておく必要のある距離が減り、記憶力が節約できてコードが読みやすくなります。
hroc135
reviewed
Jan 14, 2025
| islands.append((row - 1, col)) | ||
| islands.append((row, col + 1)) | ||
| islands.append((row, col - 1)) | ||
| return num_area |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/max-area-of-island/description/