Skip to content
This repository was archived by the owner on Apr 2, 2021. It is now read-only.

Fix/back2resp2 #95

Merged
merged 41 commits into from
Mar 23, 2019
Merged

Fix/back2resp2 #95

merged 41 commits into from
Mar 23, 2019

Conversation

kasvith
Copy link
Owner

@kasvith kasvith commented Mar 23, 2019

Pull Request for issue #94

Description

  • Refactored code
  • Moved resp3 pkg to resp directory
  • Implemented resp2 protocol
  • Used client-centric method to write
  • Opt out some tests, they will be back again
  • Implemented wire protocol

Fixes #87 #88

Testing Instructions

Excepted Behavior

Actual Behavior

Additional Comments

kasvith added 30 commits March 16, 2019 14:20
goimported
go import
commented

Verified

This commit was signed with the committer’s verified signature.
kasvith Kasun Vithanage
fixed errors by go vet

Verified

This commit was signed with the committer’s verified signature.
kasvith Kasun Vithanage
commented

Verified

This commit was signed with the committer’s verified signature.
kasvith Kasun Vithanage
go imported
commented

Verified

This commit was signed with the committer’s verified signature.
kasvith Kasun Vithanage
go imported
commented

Verified

This commit was signed with the committer’s verified signature.
kasvith Kasun Vithanage
go imported
commented

Verified

This commit was signed with the committer’s verified signature.
kasvith Kasun Vithanage
go imported

Verified

This commit was signed with the committer’s verified signature.
kasvith Kasun Vithanage

Verified

This commit was signed with the committer’s verified signature.
kasvith Kasun Vithanage

Verified

This commit was signed with the committer’s verified signature.
kasvith Kasun Vithanage

Verified

This commit was signed with the committer’s verified signature.
kasvith Kasun Vithanage

Verified

This commit was signed with the committer’s verified signature.
kasvith Kasun Vithanage

Verified

This commit was signed with the committer’s verified signature.
kasvith Kasun Vithanage

Verified

This commit was signed with the committer’s verified signature.
kasvith Kasun Vithanage
added NewClient method

Verified

This commit was signed with the committer’s verified signature.
kasvith Kasun Vithanage

Verified

This commit was signed with the committer’s verified signature.
kasvith Kasun Vithanage

Verified

This commit was signed with the committer’s verified signature.
kasvith Kasun Vithanage
moved from resp3 -> resp2(default)
kasvith added 11 commits March 22, 2019 08:41

Verified

This commit was signed with the committer’s verified signature.
kasvith Kasun Vithanage

Verified

This commit was signed with the committer’s verified signature.
kasvith Kasun Vithanage

Verified

This commit was signed with the committer’s verified signature.
kasvith Kasun Vithanage

Verified

This commit was signed with the committer’s verified signature.
kasvith Kasun Vithanage
go fmted
@kasvith kasvith self-assigned this Mar 23, 2019
@kasvith kasvith added level:expert issues that requires expert knowledge server issues related to kache-server RESP2 Regarding RESP2 Protocol RESP3 Regarding RESP3 Protocol labels Mar 23, 2019
@kasvith kasvith added this to the First Release milestone Mar 23, 2019
@kasvith kasvith merged commit 3687a80 into master Mar 23, 2019
@kasvith kasvith deleted the fix/back2resp2 branch March 24, 2019 09:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
level:expert issues that requires expert knowledge RESP2 Regarding RESP2 Protocol RESP3 Regarding RESP3 Protocol server issues related to kache-server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant