Skip to content
This repository was archived by the owner on Apr 2, 2021. It is now read-only.

Telnet clients broken #87

Closed
kasvith opened this issue Sep 6, 2018 · 4 comments
Closed

Telnet clients broken #87

kasvith opened this issue Sep 6, 2018 · 4 comments
Assignees
@kasvith @chyroc
Labels
bug Something isn't working level:intermediate issues that requires intermediate knowledge server issues related to kache-server
Milestone
First Release

Comments

@kasvith
Copy link
Owner

kasvith commented Sep 6, 2018

Description
After merge of #84 the telnet client does not work anymore

Steps to reproduce the behavior:

  • open telnet and connect to kache
  • issue a command

Expected behavior

  • reply from kache in correct format

Actual Behavior

  • command is not parsed anymore

OS and Other informations

Additional details
@kasvith kasvith added bug Something isn't working level:intermediate issues that requires intermediate knowledge server issues related to kache-server labels Sep 6, 2018
@kasvith kasvith added this to the First Release milestone Sep 6, 2018
@kasvith kasvith self-assigned this Sep 6, 2018
@kasvith
Copy link
Owner Author

kasvith commented Sep 13, 2018

@chyroc can you take a look?

@chyroc
Copy link
Collaborator

chyroc commented Sep 13, 2018 •
edited
Loading

image
telnet send \r\n, but resp3 need only \n.

@kasvith
Copy link
Owner Author

kasvith commented Sep 13, 2018

we need to handle this mechanism to a parser which tries to process <string>\r\n, commands are space separated, will discuss with you soon after my exams

@kasvith
Copy link
Owner Author

kasvith commented Mar 9, 2019

By seeing redis authors blog he will not remove backward compatibility of resp2
So we need to mainly support RESP and we need to keep RESP3 as experimental

Antirez's note

So we need to revert back

@kasvith kasvith mentioned this issue Mar 23, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kasvith kasvith

@chyroc chyroc

Labels
bug Something isn't working level:intermediate issues that requires intermediate knowledge server issues related to kache-server
Projects
None yet
Milestone
First Release
Development

No branches or pull requests
2 participants
@kasvith @chyroc