-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fourier features #124
Open
UPstartDeveloper
wants to merge
16
commits into
karpathy:master
Choose a base branch
from
UPstartDeveloper:fourier-features
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fourier features #124
UPstartDeveloper
wants to merge
16
commits into
karpathy:master
from
UPstartDeveloper:fourier-features
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om the Pooling Layer class).
…ssians by default
您好,我是薛文毅,已收到您的邮件,一会查收,谢谢!!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #121. It's not perfect but I'd love to get folks' feedback on the current state of this code on this branch!
Change Summary:
FourierFeatureLayer
, and demo its usage by including it in the default neural network defined in theimage_regression.js
fileimage_regression.html
(in addition to keeping @karpathy 's Twitter handle link). Happy to keep working on this example and/or engage in further discussion about it!Known limitations:
0
forgaussian_mapping_scale
causes the loss of the model to plateau. For now I've set it so that it defaults to use using sinusoidal functions in the mapping (please the paper I'm working off of in case that sentence doesn't make sense).image_regression.js
causes the wall clock time for training to increase, and increases proportional to how highgaussian_mapping_scale
.