Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fourier features #124

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

UPstartDeveloper
Copy link

@UPstartDeveloper UPstartDeveloper commented Jan 7, 2023

Closes #121. It's not perfect but I'd love to get folks' feedback on the current state of this code on this branch!

Change Summary:

  1. I added a new layer class called FourierFeatureLayer, and demo its usage by including it in the default neural network defined in the image_regression.js file
  2. I added my contact link in image_regression.html (in addition to keeping @karpathy 's Twitter handle link). Happy to keep working on this example and/or engage in further discussion about it!

Known limitations:

  1. For some reason, passing a value greater than 0 for gaussian_mapping_scale causes the loss of the model to plateau. For now I've set it so that it defaults to use using sinusoidal functions in the mapping (please the paper I'm working off of in case that sentence doesn't make sense).
  2. the addition of the Fourier Feature layer in image_regression.js causes the wall clock time for training to increase, and increases proportional to how high gaussian_mapping_scale.

@371148606
Copy link

371148606 commented Jan 7, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Suggestion for "Painting"] Use of Fourier Features?
2 participants