Several updates/fixes to the options passed to browsers #277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following changes:
ChromeBrowser
andChromiumBrowser
.getOptions
instead of duplicating code.Previously, chrome had these options added to it to fix a bug, however they were not added to chromium.
--disable-renderer-backgrounding
to chromium--disable-device-discovery-notifications
to chromium--password-store=basic
. Prevents gnome keyring/kde wallet popup on Linux.--use-mock-keychain
. Prevents permissions dialog on Mac.--disable-popup-blocking
. Disables the "block popups" dialog.--disable-notifications
. Disable notifications.--mute-audio
. Mute audio.--disable-client-side-phishing-detection
. Disables client-side phishing detection.--disable-translate
with--disable-features=Translate
I personally was running into an issue with the lack of
--password-store=basic
causing chromium to repeatedly prompt for a password when running tests. Originally, this PR was going to only introduce that flag, however while modifying the code to add this, I noticed a few other minor changes I could do, which is why this PR contains a few changes.If any of the new flags introduced are blocking a merge, then I can remove them, as I'd like to get
--password-store=basic
merged.