Disable proxy discovery in headless mode. #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failure unrelated to PR: |
|
@alancnet thanks for submitting this PR and sorry for the delay responding. It's been a while since this PR was created. Can you confirm the issue still occurs? |
rogeriopvl
requested changes
Nov 19, 2018
| @@ -165,7 +165,7 @@ ChromeBrowser.prototype = { | |||
| ChromeBrowser.$inject = ['baseBrowserDecorator', 'args'] | |||
|
|
|||
| function headlessGetOptions (url, args, parent) { | |||
| return parent.call(this, url, args).concat(['--headless', '--disable-gpu', '--remote-debugging-port=9222']) | |||
| return parent.call(this, url, args).concat(['--headless', '--disable-gpu', '--remote-debugging-port=9222', '--proxy-server="direct://"', '--proxy-bypass-list=*']) | |||
There was a problem hiding this comment.
Could you please refactor this line into multiple lines please?
|
@rogeriopvl Sorry for the delay. After Thanksgiving, I've been occupied in another project. I will revisit this as soon as I can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects an issue where HeadlessChrome downloads scripts at a very slow rate. As demonstrated in the screenshot, when running headless, each script took several seconds to load, causing minutes of delay for a test run. This may not occur in all environments. Shown is Chromium 70.0.3508.0 on Windows 7 SP1.
Note: This does not occur if the
--headlessflag is removed, so this may be indicative of a bug in Chromium.