-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Better Windows Support #616
Conversation
Sorry, my first `C` project contribution coming from `C++`
raw
and noritake
output on Windows
Ready for review! Sorry in advanced for my messy code, I'm a C++ dev not C dev haha. These changes will help me bring my previous linux-only app that uses cava to Windows! Passing tests here: https://github.com/nlogozzo/cava/actions/runs/13223157589 |
looks ok when skimming through, I will have a closer look later to make sure nothing breaks. |
Alrighty sounds good! I'm available all day to fix anything that breaks lmk |
Hi, any issues? |
looks good, great work! |
Thanks! Happy to contribute :) |
Could you release this as 0.10.4? |
sure why not |
Thanks again! |
Hi! |
^ |
done |
raw
andnoritake
outputs on Windows systems.raw_target
:/dev/stdout
-->stdout
will be used-p
,-h
, etc...)-p
argumentINCTXT
on Linux but using native Windows resources)