Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: systemd double start/stop #288

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

djdv
Copy link
Contributor

@djdv djdv commented Jul 22, 2021

On other platforms, this will return an error. For the sake of consistency we may want to do it here too. It seems like a programmer error for something like a double start or double stop to succeed with a nil error.

The run refacotr started in this branch and was incorporated into a separate PR: #287
We can either drop it or wait for that and rebase or something.

The unitFile thing can also be squashed, dropped, or left as-is. It predates the other fix but isn't actually important.

djdv added 3 commits July 22, 2021 12:21
- service status was not being checked during control actions. This
  allowed for sequences like double start or double stop to proceed when
  this is likely an error. Also inconsistent with other platforms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant