Dummy change to isolate ci build failure #2494
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks, I merged the other change because the CI step was some internal code-quality check, will see how this goes |
|
seems ok |
|
Thanks @ptrthomas for letting me know about the internal quality checks. I am using the following as a pre-commit check (or similar based on the projects)
Does this still hold as a good quality gate on local for raising PRs? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
THIS IS A DUMMY PULL REQUEST TO ISOLATE CI Failure for Other Pull Requests. DO NOT MERGE
Thanks for contributing this Pull Request. Make sure that you submit this Pull Request against the
developbranch of this repository, add a brief description, and tag the relevant issue(s) and PR(s) below.