Fix issue of : Ability to set the number of threads through Maven Command Line #2373 #2377
Conversation
| @@ -179,6 +179,9 @@ public List<FeatureCall> resolveAll() { | |||
| if (ko.paths != null) { | |||
| paths = ko.paths; | |||
| } | |||
| if (ko.threads > 0) { | |||
There was a problem hiding this comment.
I think it is 1 by default because of the code in Main.java - so this may ALWAYS be true and not honor what was set via the builde . maybe ko.threads != 1 is better logic, can you test this ?
There was a problem hiding this comment.
Should be make it ko.threads > 1 or !=1 both seems fine to me, The reason why I have avoided ko.threads!=1 is what if value of threads set via build is by mistake negative or something like zero. Though this condition is also handled below, in code at https://github.com/karatelabs/karate/blob/v1.4.0/karate-core/src/main/java/com/intuit/karate/Runner.java#L271.
There was a problem hiding this comment.
@vipin1326 we could have a case where builder set it to 2 in the code but we want to force it to 1 via the env and karate.options, does that make sense ?
There was a problem hiding this comment.
@ptrthomas got your point, I have changed the check to ko.threads != 1. Also tested the same.
|
@vipin1326 really appreciate your inputs on this, and I apologize with going ahead with a fix: fb6616c |
Description
Thanks for contributing this Pull Request. Make sure that you submit this Pull Request against the
developbranch of this repository, add a brief description, and tag the relevant issue(s) and PR(s) below.