Update pgx to v5 #27
Merged
Update pgx to v5 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michiomochi
commented
Jul 16, 2024
| @@ -16,11 +16,9 @@ jobs: | |||
| # - macOS-latest | |||
| # - windows-latest | |||
| go: | |||
| - "1.22" | |||
There was a problem hiding this comment.
最新の3バージョンまでテストするようにしました。
michiomochi
commented
Jul 16, 2024
| @@ -40,7 +38,7 @@ jobs: | |||
| uses: actions/checkout@v4 | |||
|
|
|||
| - name: Lint | |||
| uses: golangci/golangci-lint-action@v4 | |||
| uses: golangci/golangci-lint-action@v6 | |||
michiomochi
commented
Jul 16, 2024
| @@ -58,11 +58,9 @@ type Job struct { | |||
| // Queryer is interface for query | |||
| type Queryer interface { | |||
| Begin(ctx context.Context) (pgx.Tx, error) | |||
| BeginFunc(ctx context.Context, f func(pgx.Tx) error) (err error) | |||
There was a problem hiding this comment.
特に内部で利用していないのに型定義をしているものがあったので不要なものを削除しました。
michiomochi
commented
Jul 16, 2024
| @@ -34,7 +34,7 @@ func openTestClientMaxConns(ctx context.Context, t testing.TB, maxConnections in | |||
| // make lifetime sufficiently long | |||
| config.MaxConnLifetime = 5 * time.Minute | |||
|
|
|||
| pool, err := pgxpool.ConnectConfig(ctx, config) | |||
| pool, err := pgxpool.NewWithConfig(ctx, config) | |||
There was a problem hiding this comment.
アップデートによる関数名変更です。
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pgxをv4.18.3からv5.6.0へアップデートします。
v4からv5のChangelogは以下の通りです。
https://github.com/jackc/pgx/blob/master/CHANGELOG.md#v500-september-17-2022
qgでは以下の軽微な影響がありました。