New test for closures #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, that's a really good test. It also broke nim which is unexpected. |
|
I fixed nim (4c7b1d6). It was just step3 and 4 that had the problem which was what I guessed given that later env handling and self-hosting worked fine. |
asarhaddon
force-pushed
the
test-closure
branch
from
7ebab4a to
22efb3d
Compare
|
I have fixed ada.2 (disabling a misguided optimization attempt by a younger me 👎 ), added trivial changes to nim (that I was investigating too), and added a similar but more simple test. |
kanaka
force-pushed
the
test-closure
branch
from
22efb3d to
d8fc593
Compare
|
I rebased the branch. There are new failures in latex3 and vbs but those don't seem related to this so I have gone ahead and merged. I filed issues for the unrelated problems: |
|
Oh, I never actually merged it. Merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found this in an old mess of experimentations with ada.2. Seems simple and worth testing.