factor: update for Factor 0.98

[mrjbq7]

Updating syntax for small changes in Factor 0.98.

[mrjbq7]

The Factor 0.98 release was in 2018. I expect a Factor 0.99 release in 2022.

Both should work with this slight change.

[dubek]

Thanks @mrjbq7 for your contribution to Mal.

I ran into several problems when testing this PR locally, see comments below:

[dubek]

Please change the URL from http:// to https:// .

[dubek]

Please add the following line at the end of Dockefile:

ENV HOME /mal

This will allow factor to create the $HOME/.cache directory.

[dubek]

Please modify the top of the Dockerfile: change FROM ubuntu:vivid to FROM ubuntu:20.04 (just to modernize the images).

[dubek]

besides this, there's another GENERIC# in line 52 which needs fixing (missing colon). I get an error:

Started with:
../factor/step7_quote/step7_quote.factor

52: GENERIC# apply 0 ( args fn -- maltype newenv/f )
            ^
No word named “GENERIC#” found in current vocabulary search path
(U) Quotation: [ c-to-factor
Testing cons function
TEST: '(cons 1 (list))' -> ['',(1)]
Exception: IOError(5, 'Input/output error')
Output before exception:
]
    Word: c-to-factor
(U) Quotation: [ [ (get-catchstack) push ] dip call => (get-catchstack) pop* ]
(O) Word: command-line-startup
(O) Word: run-script
(O) Word: run-file
(O) Word: parse-file
(O) Word: parse-stream
(O) Word: parse-fresh
(O) Word: (parse-lines)
(O) Word: (parse-until)
(O) Word: parse-until-step
(O) Word: no-word
(O) Word: throw-restarts
(O) Method: M\ object throw
(U) Quotation: [
        OBJ-CURRENT-THREAD special-object error-thread set-global
        current-continuation => error-continuation set-global
        [ original-error set-global ] [ rethrow ] bi
    ]
(cons 1 (list))

make: *** [Makefile:238: test^factor^step7] Error 1

(similarly for steps 8, 9, A)

[mrjbq7]

Hi @dubek, thank you for the review.

I believe I have fixed all of those issues, but the "Build and Test / linux" Github Action is still using old Factor, which is why it is erroring.

[dubek]

Thanks @mrjbq7 , now everything works for me locally (with your updated Dockerfile).

In order for it to work correctly, we need to wait for @kanaka to build and push the kanaka/mal-test-factor docker image from your new Dockerfile, and then re-run the "Build and Test" job.

[asarhaddon]

Hello. Just for the record, this duplicates some parts of #588

[mrjbq7]

The Dockerfile in #588 looks pretty good, the only thing it's missing from this is ENV HOME /mal.

I'd be happy to be added as a maintainer of this if it's useful.

I am one of the Factor core developers.