use ByteString.toArrayUnsafe() #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akka 2.5 does not support toArrayUnsafe()
pjfanning
force-pushed
the
array-unsafe
branch
from
5f3ce78
to
839b601
Compare
hughsimpson
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we know that the code that we pass the byte array to doesn't modify the array then this call is ok - and more efficient as we avoid cloning the array for safety purposes. This code path is a hot path. Every Akka/Pekko remote that has Kamon Context Propagation is affected by the existing array cloning.
Akka 2.5 does not support the ByteString.toArrayUnsafe() method.