Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kamon-pekko: reorder some code to avoid unnecessary eval #1364

Merged
merged 1 commit into from
Oct 10, 2024
Merged

kamon-pekko: reorder some code to avoid unnecessary eval #1364

merged 1 commit into from
Oct 10, 2024

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Sep 19, 2024 •
edited
Loading

  • some vals are only needed if the Kamon.filter call returns true
  • started with kamon-pekko but have added similar changes for kamon-akka now

@pjfanning
Copy link
Contributor Author

one of the kamon-jdbc CI tests failed but none of the akka/pekko ones did

@pjfanning pjfanning force-pushed the kamon-pekko-reorder-some-code-to-avoid-unnecessary-eval branch from 1d7626e to 0b988fc Compare September 28, 2024 20:27
@pjfanning
Copy link
Contributor Author

@hughsimpson I rebased this and the CI tests passed the 2nd time around

@hughsimpson
Copy link
Contributor

Thanks for this. I'll try to check out your prs in the next couple of days

@hughsimpson hughsimpson merged commit 28e2310 into kamon-io:master Oct 10, 2024
2 checks passed
@pjfanning pjfanning deleted the kamon-pekko-reorder-some-code-to-avoid-unnecessary-eval branch October 10, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hughsimpson hughsimpson hughsimpson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjfanning @hughsimpson