-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup preview.sh template #285
Conversation
As a user recently pointed out, there was quite some misleading stuff in the ChangesIntro CommentThe intro comment in the script has been rewritten. It was still describing the ranger usage. Exit CodesJoshuto seems to only check for exit code 1 / != 1. So, the table of exit codes in the script's intro comment has been cut down to the values 0 and 1. This should match the Joshuto functionality. All Remove --image-cacheThe QuestionI thought about removing also the Actually, also the Side NoteI think it would be a good idea to change the struct pub struct FilePreview {
pub status: std::process::ExitStatus,
pub output: String,
pub index: usize,
pub modified: time::SystemTime,
} so that the status is a meaningful enumeration. If I will ever pick up a feature that introduces a new exit-code logic, I would do that.... |
Removed ranger residuals and dead code from the preview.sh script and the logic that invokes it.
Oh yeah, and I re-activated the preview for video/audio and for PDF. Not sure why these parts where commented out? Also, the preview of epub now also uses bat for coloring the markdown translation. |
Yeah, this was due for change 👍
Yeah, I was thinking down the line we would implement the rest.
This was also residual from ranger.
Yeah, I think it can be removed for text previews, but it is required for image previews.
Yes, you are correct here.
Yeah that works 👍 Let me know if you have any other questions. |
Hi @kamiyaa, this is ready for review, just in case it got missed. 😉 |
LGTM, thanks! |
Removed ranger residuals and dead code from the preview.sh script and the logic that invokes it.