-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solving the named parameters incompatibility #50
Conversation
@impronta48 Thank you for your contribution. For some reason, tests are failing. I will double-check what's going on during the week (hopefully). |
This test failure may have started to occur with the removal of - /* Mark all of these aliases deprecated. They aren't actual Redis commands. */
- PHP_MALIAS(Redis, delete, del, arginfo_del, ZEND_ACC_PUBLIC | ZEND_ACC_DEPRECATED)
- PHP_MALIAS(Redis, evaluate, eval, arginfo_eval, ZEND_ACC_PUBLIC | ZEND_ACC_DEPRECATED)
- PHP_MALIAS(Redis, evaluateSha, evalsha, arginfo_evalsha, ZEND_ACC_PUBLIC | ZEND_ACC_DEPRECATED)
- PHP_MALIAS(Redis, getKeys, keys, arginfo_keys, ZEND_ACC_PUBLIC | ZEND_ACC_DEPRECATED) |
@impronta48 Could you rebase your changes over |
- RequestHandlerComponent might not have CONTENT_TYPE env set - basics.php might not have SCRIPT_URI env set
…nto event_manager
I've rebased master. Would be great if you could merge my data. |
There was a problem on event dispatch, complaining about named parameters