Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solving the named parameters incompatibility #50

Merged
merged 7 commits into from
Oct 23, 2023

Conversation

impronta48
Copy link
Contributor

There was a problem on event dispatch, complaining about named parameters

@kamilwylegala
Copy link
Owner

@impronta48 Thank you for your contribution. For some reason, tests are failing. I will double-check what's going on during the week (hopefully).

@tenkoma
Copy link
Contributor

tenkoma commented Oct 16, 2023

There was 1 error:

1) RedisEngineTest::testClear
Error: Call to undefined method Redis::getKeys()

/home/runner/work/cakephp2-php8/cakephp2-php8/lib/Cake/Cache/Engine/RedisEngine.php:190
/home/runner/work/cakephp2-php8/cakephp2-php8/lib/Cake/Cache/Cache.php:469
/home/runner/work/cakephp2-php8/cakephp2-php8/lib/Cake/Test/Case/Cache/Engine/RedisEngineTest.php:313

This test failure may have started to occur with the removal of Redis::getKeys() in PhpRedis 6.0.0, released in September 2023.

phpredis/phpredis@de98515#diff-a1471159ac00556a439382b010c89a8507ebc6f03311ec7655cebd95dc6c978eL462-L466

-     /* Mark all of these aliases deprecated.  They aren't actual Redis commands. */
-      PHP_MALIAS(Redis, delete, del, arginfo_del, ZEND_ACC_PUBLIC | ZEND_ACC_DEPRECATED)
-      PHP_MALIAS(Redis, evaluate, eval, arginfo_eval, ZEND_ACC_PUBLIC | ZEND_ACC_DEPRECATED)
-      PHP_MALIAS(Redis, evaluateSha, evalsha, arginfo_evalsha, ZEND_ACC_PUBLIC | ZEND_ACC_DEPRECATED)
-      PHP_MALIAS(Redis, getKeys, keys, arginfo_keys, ZEND_ACC_PUBLIC | ZEND_ACC_DEPRECATED)

@kamilwylegala
Copy link
Owner

@impronta48 Could you rebase your changes over master. I fixed getKeys issue, after that tests should be green.

Jan Pešek and others added 4 commits October 20, 2023 09:26
- RequestHandlerComponent might not have CONTENT_TYPE env set
- basics.php might not have SCRIPT_URI env set
@impronta48
Copy link
Contributor Author

I've rebased master. Would be great if you could merge my data.
Thanks
Massimo

@kamilwylegala kamilwylegala merged commit 1cd99ff into kamilwylegala:master Oct 23, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants