feat(#46): get rid of (some) PHP deprecation warnings #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use issets, default local var values, better/newer language constructs
|
Looks good. Thank you for your contribution! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some deprecation warnings that are appearing on PHP8 if you turn the
E_USER_DEPRECATEDerror_reporting level ON.The PR probably does not get rid of ALL the deprecation warnings, but it resolves at least some of them (the ones that seemed to occur on almost every page multiple times for us).
The changes should not change any functionality, only changing the code to bude up-to-date with PHP8 "stricter standards".
The motivation is to allow users of this php8 version of Cake2 to turn change the error_reporting to a level that includes the deprecation warning and to be able to clean up the manually written code of all deprecations without the report being too cluttered with warnings from the framework itself.