Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SwitchEntity to select internal or external sensor #281

Merged

Conversation

Simonh98
Copy link
Contributor

Currently, the use of an external temperature sensor is only indicated by a binary_sensor. This small pull request adds the ability to specify the use of the external sensor via a switch.

@kamaradclimber
Copy link
Owner

Thanks for the contribution, could you also remove the binary sensor definition. It would allow to avoid duplicates.

@Simonh98
Copy link
Contributor Author

Thanks for the contribution, could you also remove the binary sensor definition. It would allow to avoid duplicates.

Thanks for your feedback. I've removed the corresponding binary_sensor.

@kamaradclimber kamaradclimber merged commit c5ae78e into kamaradclimber:main Feb 15, 2025
2 checks passed
@wltng
Copy link

wltng commented Feb 15, 2025

Aren't all the switches available as binary sensors (for readonly purposes)?
Besides, removing entities means it is a breaking change. People might have automations running dependent on the removed entity. It might not be a good idea to just remove them.

@kamaradclimber
Copy link
Owner

I've added a message in the release notes to warn people indeed. Thanks for the remark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants