Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-9108): add advertiserName for KAVA ad report #124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(FEC-9108): add advertiserName for KAVA ad report #124

wants to merge 1 commit into from

Conversation

RoyBregman
Copy link
Contributor

feat(FEC-9108): add advertiserName for KAVA ad report in getOptions so advertiserName is available in Kava reports

@RoyBregman RoyBregman requested a review from OrenMe July 15, 2019 14:17
OrenMe
OrenMe approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@OrenMe OrenMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can merge it without the “for Kava event” in title.
Do you have a test for ad event? If we have a test to add here let’s add it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RoyBregman @OrenMe