Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add #EXT-X-INDEPENDENT-SEGMENTS to hls manifests #606

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add #EXT-X-INDEPENDENT-SEGMENTS to hls manifests #606

wants to merge 1 commit into from

Conversation

erankor
Copy link
Contributor

@erankor erankor commented May 18, 2017

when vod_align_segments_to_key_frames is on

@erankor
add #EXT-X-INDEPENDENT-SEGMENTS to hls manifests
12d8d94 
when vod_align_segments_to_key_frames is on
@feedanal
Copy link

why wasn't this merged may I ask?

@erankor
Copy link
Contributor Author

erankor commented Dec 27, 2022

Mostly because we didn't have a strong-enough reason to do it...
As you can imagine, changing all the HLS manifest responses is not a small risk - it's impossible to tell which player will choke on it. Specifically for this change, I'm quite sure I read somewhere about a player that failed because of #EXT-X-INDEPENDENT-SEGMENTS.
When we started our live project (https://github.com/kaltura/media-framework/), this tag was already defined, and we weren't concerned about backward compatibility, so we returned this tag right from the first version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erankor @feedanal