Fix reported issues w.r.t python2.7 and some apple silicone quirks #4924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csukuangfj
reviewed
Jul 22, 2024
|
@csukuangfj hi, good point, changed. I also fixed the failing tests while I was at it -- authors of the tests forgot that |
|
I'm surprised some of these issues lasted as long as they have, about the templates. anyway looks OK to me. |
|
I'm surprised too, but some stuff we ignored and some stuff the older compilers didn't complain about... 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@danpovey for your reviewing pleasure ;)