Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Qt Installer Framework #314

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added Qt Installer Framework #314

wants to merge 1 commit into from

Conversation

KOLANICH
Copy link
Contributor

@KOLANICH KOLANICH commented Aug 17, 2020 •
edited
Loading

Since my PR into QIF repo was ignored for years, it seems they are both disinterested in maintaining the spec and disrespectful enough to just ignore PRs. So I post the spec here.

Fixes: #225

generalmimon
generalmimon reviewed Aug 17, 2020
View reviewed changes
archive/qt_installer_framework.ksy
Qt installer framework is a set of libs to make SFX installers. Installers usually contain 7zip-compressed archives. Obviously, Qt installer itself is built using this framework.

Warning 1: KSC has a bug. It makes the computed values be int32_t. Of course their type should be either explicitly specified by a programmer or derived automatically. The workaroind is to just replace all int32_t to int64_t in sources.
Warning 2: don't use this spec on Linux against Qt distribution with overcommit enabled unless you have lot of RAM (> 12 GiB). There is a severe memory leak somewhere (currently I have no idea where exactly). The leak is present in both C++ and python-compiled code. In python even if I have patched the generated source to explicitly free all the `bytes`, `BytesIO`s and `KaitaiStream` objects the leak is still present. At least it is neither in `bytes` nor in `BytesIO`. In C++ I have not patched anything but used move semantics to free the stuff since std::unique_ptr is used. The leak is still present. IDK where it is and how to fix it.
Copy link
Member

@generalmimon generalmimon Aug 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please wrap the long lines to be at most 80 characters long, as the KSY Style Guide recommends?

Lines should be wrapped to be 80 columns long. If it doesn’t fit into single line after wrapping, then it’s a multi-line docstring, so use proper multi-line syntax.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am against manual wrapping. Instead wrapping must be done by a text editor depending on window size.

@KOLANICH KOLANICH force-pushed the qt_installer_framework branch 2 times, most recently from b6d0770 to 2e7ea60 Compare January 18, 2021 17:22
@KOLANICH KOLANICH force-pushed the qt_installer_framework branch 3 times, most recently from 66046ab to be4f31a Compare March 10, 2021 17:20
@KOLANICH KOLANICH force-pushed the qt_installer_framework branch 2 times, most recently from dedbe78 to 89f2ab9 Compare April 19, 2021 18:09
@KOLANICH KOLANICH mentioned this pull request Apr 23, 2021
Closed
@KOLANICH KOLANICH force-pushed the qt_installer_framework branch 2 times, most recently from f15c126 to 43f4931 Compare April 30, 2021 14:18
@KOLANICH KOLANICH force-pushed the qt_installer_framework branch 3 times, most recently from 0185a7f to ec15491 Compare July 5, 2021 17:25
@KOLANICH KOLANICH force-pushed the qt_installer_framework branch 2 times, most recently from 37ba021 to 9cee143 Compare September 3, 2021 16:56
@KOLANICH KOLANICH force-pushed the qt_installer_framework branch 2 times, most recently from d9aa1dc to 3a0553a Compare September 14, 2021 18:51
@KOLANICH KOLANICH force-pushed the qt_installer_framework branch 2 times, most recently from 5f1d675 to 4b1c257 Compare October 28, 2021 17:28
@KOLANICH KOLANICH force-pushed the qt_installer_framework branch 2 times, most recently from 8fb22dc to 04b2b3e Compare May 31, 2022 10:47
@KOLANICH KOLANICH force-pushed the qt_installer_framework branch 2 times, most recently from 7188255 to 34ba365 Compare March 20, 2023 13:20
@KOLANICH KOLANICH force-pushed the qt_installer_framework branch 2 times, most recently from 19aba8a to 9b28feb Compare March 28, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@generalmimon generalmimon generalmimon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Qt Installer Framework
2 participants
@KOLANICH @generalmimon