Fix round-off-one errors in Random.between max bounds

kaist-plrg · Mar 11, 2024 · bd85b99 · bd85b99
1 parent 0442950
commit bd85b99
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/main/scala/fhetest/Generate/LibConfigGenerator.scala b/src/main/scala/fhetest/Generate/LibConfigGenerator.scala
@@ -48,15 +48,15 @@ def generateLibConfig(encType: ENC_TYPE, valid: Boolean): LibConfig = {
     if valid then
       randomScheme match {
         case Scheme.BFV | Scheme.BGV =>
-          Some(Random.between(1, randomEncParams.plainMod))
+          Some(Random.between(1, randomEncParams.plainMod + 1))
         case Scheme.CKKS =>
-          Some(Random.between(1, math.pow(2, randomFirstModSize)))
+          Some(Random.between(1, math.pow(2, randomFirstModSize) + 1))
       }
     else
       randomScheme match {
         case Scheme.BFV | Scheme.BGV =>
-          Some(Random.between(1, 1000))
-        case Scheme.CKKS => Some(Random.between(1, math.pow(2, 64)))
+          Some(Random.between(1, 1000 + 1))
+        case Scheme.CKKS => Some(Random.between(1, math.pow(2, 64) + 1))
       }
   LibConfig(
     randomScheme,

diff --git a/src/main/scala/fhetest/Phase/Check.scala b/src/main/scala/fhetest/Phase/Check.scala
@@ -107,7 +107,7 @@ case object Check {
       } else {
         if (debug) {
           println(
-            s"Program $i is skipped due to HE overflow check: 2^$overflowBound",
+            s"Program $i is skipped due to HE overflow check: $overflowBound",
           )
         }
         None