Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keylime example #2981

Merged
merged 7 commits into from
Nov 13, 2024
Merged

keylime example #2981

merged 7 commits into from
Nov 13, 2024

Conversation

Itxaka
Copy link
Member

@Itxaka Itxaka commented Nov 4, 2024

Signed-off-by: Itxaka [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@Itxaka Itxaka requested a review from a team November 4, 2024 08:50
@Itxaka Itxaka marked this pull request as ready for review November 8, 2024 11:01
@mudler
Copy link
Member

mudler commented Nov 8, 2024

Nice! ➕

The only thing from my side is that given the topic complexity would be probably helpful for users to have a small README on how to tie all the pieces in, and maybe a mention of it in the docs, otherwise the example by itself is going to be hard to consume

@Itxaka
Copy link
Member Author

Itxaka commented Nov 8, 2024

Nice! ➕

The only thing from my side is that given the topic complexity would be probably helpful for users to have a small README on how to tie all the pieces in, and maybe a mention of it in the docs, otherwise the example by itself is going to be hard to consume

Indeed, maybe all the comments on the cc fili would be better served on a readme

Itxaka and others added 2 commits November 11, 2024 09:33
Co-authored-by: Ettore Di Giacinto <[email protected]>
Signed-off-by: Itxaka <[email protected]>
@Itxaka Itxaka requested review from mudler, a team and Copilot November 11, 2024 10:35
@Itxaka
Copy link
Member Author

Itxaka commented Nov 11, 2024

expanded to show a bit more, link to docs and so on

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 suggestion.

Files not reviewed (1)
  • examples/keylime/Dockerfile: Language not supported
Comments skipped due to low confidence (2)

examples/keylime/README.md:6

  • The word 'thee' should be 'the'.
We provide thee keylime agent as a luet package for ease of installation.

examples/keylime/README.md:7

  • The word 'installeed' should be 'installed'.
For it to be installeed you need to create your own derivative of the Kairos image and add the keylime-agent package to it.

examples/keylime/README.md Outdated Show resolved Hide resolved
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Itxaka <[email protected]>
examples/keylime/README.md Outdated Show resolved Hide resolved
Copy link
Member

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a very good and detailed example, thanks @Itxaka !

Co-authored-by: Ettore Di Giacinto <[email protected]>
Signed-off-by: Itxaka <[email protected]>
@Itxaka Itxaka merged commit 83cda74 into master Nov 13, 2024
8 of 18 checks passed
@Itxaka Itxaka deleted the keylime branch November 13, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants