-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keylime example #2981
keylime example #2981
Conversation
Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Itxaka <[email protected]>
Nice! ➕ The only thing from my side is that given the topic complexity would be probably helpful for users to have a small README on how to tie all the pieces in, and maybe a mention of it in the docs, otherwise the example by itself is going to be hard to consume |
Indeed, maybe all the comments on the cc fili would be better served on a readme |
Co-authored-by: Ettore Di Giacinto <[email protected]> Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Itxaka <[email protected]>
expanded to show a bit more, link to docs and so on |
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 suggestion.
Files not reviewed (1)
- examples/keylime/Dockerfile: Language not supported
Comments skipped due to low confidence (2)
examples/keylime/README.md:6
- The word 'thee' should be 'the'.
We provide thee keylime agent as a luet package for ease of installation.
examples/keylime/README.md:7
- The word 'installeed' should be 'installed'.
For it to be installeed you need to create your own derivative of the Kairos image and add the keylime-agent package to it.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Itxaka <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a very good and detailed example, thanks @Itxaka !
Co-authored-by: Ettore Di Giacinto <[email protected]> Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Itxaka [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #