Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐧 Bring back ubuntu 24.10 uki #2939

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🐧 Bring back ubuntu 24.10 uki #2939

wants to merge 1 commit into from

Conversation

Itxaka
Copy link
Member

@Itxaka Itxaka commented Oct 14, 2024

on 24.10 systemd-cryptsetup is installed explicitely and no longer comes witht eh systemd base package

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2937

on 24.10 systemd-cryptsetup is installed explicitely and no longer comes
witht eh systemd base package

Signed-off-by: Itxaka <[email protected]>
@Itxaka Itxaka requested review from mauromorales and a team October 14, 2024 09:47
Copy link
Member

@mauromorales mauromorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

@@ -154,8 +154,10 @@ RUN [ -z "$(ls -A /lib/firmware/intel-ucode/)" ] && apt-get update && apt-get in
FROM systemd-boot AS systemd-boot-arm64

FROM systemd-boot-amd64 AS systemd-boot-amd64-24.10
RUN apt-get update && apt-get install -y systemd-cryptsetup && apt-get remove -y unattended-upgrades && apt-get clean && rm -rf /var/lib/apt/lists/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we always have to remove unattended-upgrades after anything we install? Is it a dependency all all packages somehow?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea. Monkey see, monkey do. :D

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe good question, maybe it can be run just once, I didn't really dig deep enough into it

@Itxaka Itxaka added the blocked label Oct 14, 2024
@Itxaka
Copy link
Member Author

Itxaka commented Oct 14, 2024

actually other than this it requires a fixed systemd version lol

@mauromorales
Copy link
Member

@Itxaka 😢 but it's cool that this is clear now, thanks for testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check ubuntu 24.10 uki
3 participants