Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Videos in Tutorials #172

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

mdienst
Copy link
Contributor

@mdienst mdienst commented Aug 22, 2024

  • Added a video of the wave propagation in a thin bar and
  • Changed the embedding of mp4 files in tutorials to make them accessible in all browsers.

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.34%. Comparing base (911f762) to head (1fbe0d4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
- Coverage   90.39%   90.34%   -0.05%     
==========================================
  Files          43       43              
  Lines        4050     4050              
==========================================
- Hits         3661     3659       -2     
- Misses        389      391       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@kaipartmann kaipartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaipartmann
Copy link
Owner

The video of the tutorial is related to the question in the review #168.

@kaipartmann kaipartmann merged commit 44762cc into kaipartmann:main Aug 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants