Change multithreading backend to Base.Threads #153
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The multithreading backend is changed. All previous
Polyester.@batch
calls are replaced withThreads.@threads :static
calls. This is now possible due to the changes in trixi-framework/PointNeighbors.jl#61 with PointNeighbors.jl v0.4.5.As shown in the PR, this will result in a improved performance.
Benchmark with 64 Threads:
Due to the Polyester-Threads mixing issue I thought it could be a good idea to also use
Polyester.@batch
, so it is used for every multithreading loop in the package inv0.3.0
:However, I found out this was the reason my parallel performance for single body simulations is not as good as before. When changing all
Polyester.@batch
statements inPeridynamics.jl
to@threads :static
calls, the performance of contact simulations also improves (ifPointNeighbors.jl
also uses@threads :static
):