[WIP] - Remove returns dependency #53
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasborgen
force-pushed
the
breaking/remove-returns-dependency
branch
from
47e1389
to
2dbcf1c
Compare
* removes safe apply_casting * removes function apply default * removes safe apply if statement function * removes safe apply regex funciton * removes safe apply separator function * removes unused old functions * fixes set value in dict function * removes returns from fetch list by keys function * removes old fetch list by keys function * removes returns from fetch data by keys function * removes returns from iterable data handler * removes unused returns imports * Breaking/remove returns dependency normal handlers (#60) * remove returns from handle_data_fetcher * removes returns from handle_attribute * removes returns imports * Breaking/remove returns dependency casting (#64) * removes returns from cast to decimal * removes returns import from decimal tests * removes returns from cast to integer * removes returns from cast to date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it should be quite okay to remove
returnsdependency.Things will get easier to follow for anyone unfamiliar with
returnsand it feels like we adopted it too soon.