-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kaiax/builder: Introduce TxOrGen #289
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulbqb
reviewed
Mar 20, 2025
Mdaiki0730
reviewed
Mar 20, 2025
Mdaiki0730
approved these changes
Mar 21, 2025
ulbqb
approved these changes
Mar 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
ApproveTx.Hash || SwapTx.Hash
. Previously, hash was initialized atincorporate
lazily, which resulted in TxGenerators having incorrect hashes. TxGenerator's type is reverted back to function.TxOrGen
; it replaces[]interfaces{}
array from builder.txOrGen
can be evaluated to tx byGetTx(nonce)
.Has(hash common.Hash)
->Has(txOrGen *TxOrGen)
. To find by hash,FindIdx(id common.Hash)
can be used.markAllTxUnexecutable
.tests/kaia_test_account_map_test.go
so txOrGen is evaluated to tx in the correct order.Types of changes
Checklist
I have read the CLA Document and I hereby sign the CLA
in first time contribute$ make test
)